Re: "undefined behavior"?

On 6/13/2024 3:25 AM, Ike Naar wrote:

On 2024-06-12, DFS <nospam@dfs.com> wrote:

//no outliers
if ( min > lo && max < hi) {

 The condition for 'no outliers' is not the complement of
  the condition for 'at least one outlier' below.

You're saying some outliers will not be flagged?

strcat(outliers,"none      (using IQR * 1.5 rule)");
}
>
//at least one outlier
if ( min < lo || max > hi) {
for(i = 0; i < N; i++) {
double val = (double)nums[i];
if(val < lo || val > hi) {
sprintf(temp,"%.0f ",val);
temp[strlen(temp)] = '\0';

 This is unnecessary;
sprintf terminates the generated string with a null character.

Thanks.

strcat(outliers,temp);
}
}
strcat(outliers," (using IQR * 1.5 rule)");
}