Re: Cray style vectors

Terje Mathisen <terje.mathisen@tmsw.no> writes:

Tim Rentsch wrote:
>

Terje Mathisen <terje.mathisen@tmsw.no> writes:
>

If I really had to write a 64x64->128 MUL, with no widening MUL or
MULH which returns the high half, then I would punt and do it using
32-bit parts (all variables are u64):  [...]

>
I wrote some code along the same lines.  A difference is you
are considering unsigned multiplication, and I am considering
signed multiplication.

>
Signed mul is just a special case of unsigned mul, right?
>
I.e. in case of a signed widening mul, you'd first extract the signs,
convert the inputs to unsigned, then do the unsigned widening mul,
before finally resotirng the sign as the XOR of the input signs?
>
There is a small gotcha if either of the inputs are of the 0x80000000
form, i.e. MININT, but the naive iabs() conversion will do the right
thing by leaving the input unchanged.
>
At the other end there cannot be any issues since restoring a negative
output sign cannot overflow/fail.

It isn't quite that simple.  Some of what you describe has a risk
of running afoul of implementation-defined behavior or undefined
behavior (as for example abs( INT_MIN )).  I'm pretty sure it's
possible to avoid those pitfalls, but it requires a fair amount
of care and careful thinking.

Note that my goal is only to avoid the possibility of undefined
behavior that comes from signed overflow.  My approach is to safely
determine whether the signed multiplication would overflow, and if
it wouldn't then simply use signed arithmetic to get the result.
I use unsigned types to determine the safety, and if it's safe then
using signed types to get a result.  For the current problem I don't
care about widening, except as it might help to determine safety.