Re: Fixing a sample from K&R book using cake static analyser

On 2024-06-23, Anton Shepelev <anton.txt@gmail.moc> wrote:

Kaz Kylheku:
>

What scatter-brained drivel. Watch and learn:
>
  struct nlist *install(char *name, char *defn)
  {
    struct nlist *existing = lookup(name);
>
    if (existing) {
      return existing;
    } else {

>
When the if-branch ends with a return, the else-branch is
redundant, and its body shall be written bare, removing one
(useless) level of nesting and indentation.

I did that because there are declarations in the else case.

I avoid mising declarations and statements, because I consider
that a language misfeature.

In a block structured language, declarations should come first,
then statements.

--
TXR Programming Language: http://nongnu.org/txr
Cygnal: Cygwin Native Application Library: http://kylheku.com/cygnal
Mastodon: @Kazinator@mstdn.ca