Re: So You Think You Can Const?

On 2025-01-09, Ben Bacarisse <ben@bsb.me.uk> wrote:

Julio Di Egidio <julio@diegidio.name> writes:
>

static AvlTree_t const *AvlTree_node(
    void const *pk, AvlTree_t const *pL, AvlTree_t const *pR
) {
    AvlTree_t *pT;
>
    pT = malloc(sizeof(AvlTree_t));
>
    if (!pT) {
        return NULL;
    }
>
    pT->pk = pk;
    pT->pL = pL;
    pT->pR = pR;
>
    return pT;
}

>
Just on a side issue, I prefer to make tests like this positive so I'd
write:
>
 static AvlTree_t const *AvlTree_node(
     void const *pk, AvlTree_t const *pL, AvlTree_t const *pR
 ) {
     AvlTree_t *pT = malloc(*pT);
 
     if (pT) {
         pT->pk = pk;
         pT->pL = pL;
         pT->pR = pR;
     }
     return pT;
 }

More generally:

   foo_handle *foo = foo_create();
   bar_handle *bar = foo ? bar_create(foo) : 0; // doesn't like null
   xyzzy_handle *xyz = xyzzy_create(42, bar, arg);
   container *con = malloc(sizeof *con);

   if (foo && bar && xyz && con) {
     // happy case: we have all three resources

     con->foo = foo;
     con->bar = bar;
     con->xyz = xyz;

     return con;
   }

   xyzzy_destroy(xyz);
   xyzzy_destroy(bar);
   if (foo)
      xyzzy_destroy(foo); // stupidly doesn't like null

   return 0;

I'm not going to "make a case" for this (though I will if you want!) --
I just think it helps to see lots of different styles.

I might just have made the case. When more resources need to be
acquired that might fail, it consolidates the happy case under one
conjunctive test, and consolidates the cleanup in the unhappy case.
Effectively it's almost if we have only two cases.

A minor disadvantage is that in the unhappy flow, we may allocate
resources past the point where it is obvious they are not going to be
needed: if foo_create() failed, we are pointlessly calling
xyzzy_create() and malloc for the container. It's possible that these
succeed, and we are just going to turn around and free them.

It's a form of consolidated error checking, like when we make
several system calls and check them for errors as a batch;
e.g. call fprintf several times and check for disk full (etc)
just once.

--
TXR Programming Language: http://nongnu.org/txr
Cygnal: Cygwin Native Application Library: http://kylheku.com/cygnal
Mastodon: @Kazinator@mstdn.ca