Re: So You Think You Can Const?

Julio Di Egidio <julio@diegidio.name> writes:

static AvlTree_t const *AvlTree_node(
    void const *pk, AvlTree_t const *pL, AvlTree_t const *pR
) {
    AvlTree_t *pT;
>
    pT = malloc(sizeof(AvlTree_t));
>
    if (!pT) {
        return NULL;
    }
>
    pT->pk = pk;
    pT->pL = pL;
    pT->pR = pR;
>
    return pT;
}

Just on a side issue, I prefer to make tests like this positive so I'd
write:

 static AvlTree_t const *AvlTree_node(
     void const *pk, AvlTree_t const *pL, AvlTree_t const *pR
 ) {
     AvlTree_t *pT = malloc(*pT);
 
     if (pT) {
         pT->pk = pk;
         pT->pL = pL;
         pT->pR = pR;
     }
     return pT;
 }

I'm not going to "make a case" for this (though I will if you want!) --
I just think it helps to see lots of different styles.

--
Ben.