Re: Command line globber/tokenizer library for C?

On 18/09/2024 11:49, Bart wrote:

On 18/09/2024 09:43, Michael S wrote:

On Wed, 18 Sep 2024 01:07:17 +0100
Bart <bc@freeuk.com> wrote:

 

          return collect_word(s+1, r, (w ^ c) == '"', go);

>
That's not how it was written in original. Should be:
          return collect_word(s+1, r, w ^ c == '"', go);
Not the same thing at all.

 So, what you are saying is that it means 'w ^ (c == '"')'? Because there could be some ambiguity, I put in the brackets. I had to to guess the precedence and chose the one that seemed more plausible, but I guessed wrong.
 

There is no ambiguity in the C language - the equality operator has higher precedence than the bitwise operators and logical operators.
However, I fully agree with you that code is clearer if parenthesis are added.  It makes the code easier to read, easier to write, and eliminates the risk of programmers (either those writing the code or those reading it) getting it wrong.

Mine version then should be:
        return collect_word(s+1, r, w ^ (c == '"'), go);
 

Put spaces around the "+" operator, and it would be perfect :-)

 

The same here.

 I'm surprised there weren't more typos, but that's not what my post was about which was presentation and layout.