Re: filling area by color atack safety

On 17/03/2024 11:31, Ben Bacarisse wrote:

scott@slp53.sl.home (Scott Lurndal) writes:
 

David Brown <david.brown@hesbynett.no> writes:

On 16/03/2024 12:33, Malcolm McLean wrote:

>

And here's some code I wrote a while ago. Use that as a pattern. But not
sure how well it works. Haven't used it for a long time.
>
https://github.com/MalcolmMcLean/binaryimagelibrary/blob/master/drawbinary.c
>

>
Your implementation is a mess, /vastly/ more difficult to prove correct

>
Malcolm can't even spell 'integer' correctly in that code blob :-).

 As someone with dyslexia I have never liked mocking remarks about
spelling errors.  Using "even" suggests that a superficial issue hints
at deeper problems.  This is rarely the case.
 However, I /would/ urge Malcolm to correct the spelling if Bresenham
since the intent was clearly to credit the discoverer.  Also,
misspellings don't play well with library databases.
 

I also have dyslexia.  I am dependent on a spell checker to spell accurately.  And that is one of the reasons why Malcolm should do a better job of writing accurately - it is much easier for others to read posts when the spelling and the grammar is correct.  I would, of course, also like him to do a better job at his grammar, but using a spell-checker is so simple and low-cost that it is inexcusable for him not to use one.
I have nothing bad to say about people who can't spell well, or who can't type well, and I have nothing but respect for people who are trying their best to write in a second (or third, or more) language.
But Malcolm is a native English speaker with a degree in English.  He is not dyslexic (or at least, the mistakes he makes are not typical signs of dyslexia).  He is simply a poor typist and too lazy to make an effort to correct his errors.

Certainly the intent of Fir's algorithm is easily discerned from
his code.   I can't say that about Malcolms.

 I have some reservations about the code, but he posted a link so there
is no indication that he wants a review of it.