Re: Fixing a sample from K&R book using cake static analyser

On Fri, 21 Jun 2024 09:45:21 -0300, Thiago Adams wrote:

Page 145, The C programming Language 2 Edition
 
/* install:  put (name, defn) in hashtab */
struct nlist *install(char *name, char *defn)
{
     struct nlist *np;
     unsigned hashval;
 
     if ((np = lookup(name)) == NULL) {  /* not found */
         np = (struct nlist *) malloc(sizeof(*np));
         if (np == NULL || (np->name = strdup(name)) == NULL)
             return NULL;
         hashval = hash(name);
         np->next = hashtab[hashval];
         hashtab[hashval] = np;
     } else      /* already there */
         free((void *) np->defn);  /* free previous defn */
 
     if ((np->defn = strdup(defn)) == NULL)
         return NULL;
     return np;
}

    struct nlist *install(char *name, char *defn)
      {
        struct nlist *np = NULL;
        struct nlist *result = NULL;
        unsigned hashval;
        do /*once*/
          {
            result = lookup(name);
            if (result != NULL)
                break;
            np = (struct nlist *)calloc(1, sizeof struct nlist);
            if (np == NULL)
                break;
            np->defn = strdup(defn);
            if (np->defn == NULL)
                break;
            hashval = hash(name);
            np->next = hashtab[hashval];
            hashtab[hashval] = np;
            result = np;
            np = NULL; /* so I don’t dispose of it yet */
          }
        while (false);
        if (np != NULL)
          {
            free(np->defn);
          } /*if*/
        free(np);
        return
            result;
      } /*install*/