Re: Fixing a sample from K&R book using cake static analyser

Kaz Kylheku:

What scatter-brained drivel. Watch and learn:
>
  struct nlist *install(char *name, char *defn)
  {
    struct nlist *existing = lookup(name);
>
    if (existing) {
      return existing;
    } else {

When the if-branch ends with a return, the else-branch is
redundant, and its body shall be written bare, removing one
(useless) level of nesting and indentation.  This is how
goto's and multiple return's (which are but a special case
of goto) help tidy up code.

--
()  ascii ribbon campaign -- against html e-mail
/\  www.asciiribbon.org   -- against proprietary attachments