Re: Command line globber/tokenizer library for C?

On 18/09/2024 09:43, Michael S wrote:

On Wed, 18 Sep 2024 01:07:17 +0100
Bart <bc@freeuk.com> wrote:

I find such a coding style pretty much impossible to grasp and
unpleasant to look at. I had to refactor it like this:
>
---------------
>
static_Bool collect_word(char *s, char *r, _Bool w, Gopher go ) {
      char c = *s;
      #if 1
          if (c == 0) {
              go->f(go, r, s);
              return  w;
          }
          if (is_space(c) && w) {
              go->f(go, r, s);
              return words_do(s, go);
          }
          return collect_word(s+1, r, (w ^ c) == '"', go);

 That's not how it was written in original. Should be:
          return collect_word(s+1, r, w ^ c == '"', go);
Not the same thing at all.

So, what you are saying is that it means 'w ^ (c == '"')'? Because there could be some ambiguity, I put in the brackets. I had to to guess the precedence and chose the one that seemed more plausible, but I guessed wrong.
Mine version then should be:
       return collect_word(s+1, r, w ^ (c == '"'), go);

The same here.

I'm surprised there weren't more typos, but that's not what my post was about which was presentation and layout.