Re: Python (was Re: I did not inhale)

Lawrence D'Oliveiro <ldo@nz.invalid> writes:

On Wed, 28 Aug 2024 19:19:38 -0700, Keith Thompson wrote:

My impression is that your unconventional style indicates a relative
lack of experience in Python.

>
You think maybe I should practise by writing more Python code?

And you snipped the part where I acknowledged that might be an invalid
conclusion.  I have no opinion on what you should do.

OK, how about your thoughts on comparing this
>
    for attrname in obj.tag_attrs :
        attr = getattr(obj, attrname)
        if attr != None :
            if isinstance(attr, enum.Enum) :
                attr = attr.value
            elif isinstance(attr, Type) :
                attr = unparse_signature(attr)
            elif not isinstance(attr, str) :
                raise TypeError("unexpected attribute type %s for %s" % (type(attr).__name__, repr(attr)))
            attrs.append("%s=%s" % (attrname, quote_xml_attr(attr)))
    out.write(" " * indent + "<" + tag_name)
>
with this
>
    for attrname in obj.tag_attrs :
        attr = getattr(obj, attrname)
        if attr != None :
            if isinstance(attr, enum.Enum) :
                attr = attr.value
            elif isinstance(attr, Type) :
                attr = unparse_signature(attr)
            elif not isinstance(attr, str) :
                raise TypeError("unexpected attribute type %s for %s" % (type(attr).__name__, repr(attr)))
        attrs.append("%s=%s" % (attrname, quote_xml_attr(attr)))
    out.write(" " * indent + "<" + tag_name)

The difference is obvious: the second calls attrs.append() even if attr
is None.  I don't know what point you're trying to make.

--
Keith Thompson (The_Other_Keith) Keith.S.Thompson+u@gmail.com
void Void(void) { Void(); } /* The recursive call of the void */