Re: Python (was Re: I did not inhale)

Lawrence D'Oliveiro <ldo@nz.invalid> writes:

On Wed, 28 Aug 2024 13:29:18 -0700, Keith Thompson wrote:

But ok, I found your post and removed all the #end comments.  I found it
just as readable without them as with them.

>
You know what? You are right. That example was just too
well-structured.
>
Here’s a more dangerous one:
>
    def register_additional_standard(self, **kwargs) :
        "registers additional standard interfaces that are not automatically" \
        " installed at Connection creation time. Currently the only one is" \
        " the object-manager interface, registered with\n" \
        "\n" \
        "    «conn».register_additional_standard(managed_objects = True)\n"

That's not the conventional way to format a docstring.  If you're using
backslashes to splice lines in Python, it's likely you're doing
something wrong.

        for key in kwargs :
            if kwargs[key] :
                if key == "managed_objects" :
                    if self._managed_objects != None :

I think "is not None" is more idiomatic.

                        raise asyncio.InvalidStateError \
                          (
                            "object manager interface already registered"
                          )

You don't need the \ if you put the ( on the same line.

                    #end if
                    self.register \
                      (
                        path = "/",
                        interface = ManagedObjectsHandler(),
                        fallback = True
                      )

Again, you've decided how you want to place parentheses and you're
forcing the syntax to cater to that.  I might write that as:

                    self.register(
                        path = "/",
                        interface = ManagedObjectsHandler(),
                        fallback = True
                    )

                    self._managed_objects = {}
                else :

You leave a space between "else" and ":".  It's not wrong, but it's not
something I've ever seen.  It's likely to be just a little jarring to
readers.

                    raise TypeError("unrecognized argument keyword “%s”" % key)

Do you have a requirement to use older versions of Python that don't
support f-strings?

                #end if
            #end if
        #end for
        return \
            self

Why not just "return self"?

    #end register_additional_standard
>
versus
>
    def register_additional_standard(self, **kwargs) :
        "registers additional standard interfaces that are not automatically" \
        " installed at Connection creation time. Currently the only one is" \
        " the object-manager interface, registered with\n" \
        "\n" \
        "    «conn».register_additional_standard(managed_objects = True)\n"
        for key in kwargs :
            if kwargs[key] :
                if key == "managed_objects" :
                    if self._managed_objects != None :
                        raise asyncio.InvalidStateError \
                          (
                            "object manager interface already registered"
                          )
                    self.register \
                      (
                        path = "/",
                        interface = ManagedObjectsHandler(),
                        fallback = True
                      )
                    self._managed_objects = {}
                else :
                    raise TypeError("unrecognized argument keyword “%s”" % key)
        return self

Again, the #end comments don't make it any more readable *for me*.
I suspect that would be even more true for more experienced Python
programmers.

I was looking for quite a tricky example I remember seeing on the
ArjanCodes channel on YouTube, but I can’t find it.

In any language, if a block of code is so deeply indented that it's
confusing, you should consider refactoring it.  (Though that's not
always the answer.)

I once reviewed some C code with misleading indentation.  Depending on
the viewer's tab settings (4 vs 8 columns) it looked either like this:

    if (condition)
        this;
        that;

or like this:

    if (condition)
        this;
    that;

Of course it meant the same to the compiler.

In any language, I think it's important to use consistent indentation
that reflects the structure of the code, and to avoid mixing tabs and
spaces.  (My personal preference is to use spaces exclusively, but I'll
conform to what existing code does.)  As I've said elsethread, Python's
rules just force me to do what I would have done anyway.

--
Keith Thompson (The_Other_Keith) Keith.S.Thompson+u@gmail.com
void Void(void) { Void(); } /* The recursive call of the void */